Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: karuturi <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-40-cloudstack@git.apache.org>
In-Reply-To: <git-pr-40-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-7929: Unhandled
 exception when...
Content-Type: text/plain
Message-Id: <20141118063825.58DDB991BE0@tyr.zones.apache.org>
Date: Tue, 18 Nov 2014 06:38:25 +0000 (UTC)

Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/40#discussion_r20487864
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -3723,6 +3723,10 @@ public NetworkOffering createNetworkOffering(CreateNetworkOfferingCmd cmd) {
                 throw new InvalidParameterValueException("Invalid value for Availability. Supported types: " + Availability.Required + ", " + Availability.Optional);
             }
     
    +        if (networkRate != null && networkRate < 0) {
    --- End diff --
    
    is networkRate == null a valid value?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---