Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 183451059D for ; Mon, 17 Nov 2014 18:26:03 +0000 (UTC) Received: (qmail 49547 invoked by uid 500); 17 Nov 2014 18:26:02 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 49495 invoked by uid 500); 17 Nov 2014 18:26:02 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 49470 invoked by uid 99); 17 Nov 2014 18:26:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2014 18:26:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B0C001D398B; Mon, 17 Nov 2014 18:26:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7378270066193140720==" MIME-Version: 1.0 Subject: Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI From: "Daniel Vega Simoes" To: "Daniel Vega Simoes" , "Rajani Karuturi" , "cloudstack" Date: Mon, 17 Nov 2014 18:26:01 -0000 Message-ID: <20141117182601.24717.87731@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Daniel Vega Simoes" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/28043/ X-Sender: "Daniel Vega Simoes" References: <20141114181508.1251.24727@reviews.apache.org> In-Reply-To: <20141114181508.1251.24727@reviews.apache.org> Reply-To: "Daniel Vega Simoes" X-ReviewRequest-Repository: cloudstack-git --===============7378270066193140720== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/ ----------------------------------------------------------- (Updated Nov. 17, 2014, 6:26 p.m.) Review request for cloudstack. Changes ------- - as suggested by Rajani Karuturi, created a new function in network.js to list LB algorithms for a network. - fixed internationalization for 'label.source' - updated to use last commit on master (efe47b07044a863e5a34f48ef6e2468265925604) Repository: cloudstack-git Description ------- JIRA: CLOUDSTACK 7915 Removed hard-coded values for Load Balancer algorithms in UI. Instead, now UI sets values loaded dynamically through load balancer provider capabilities. Also updated internationalization messages. Diffs (updated) ----- client/WEB-INF/classes/resources/messages.properties 86eb5c2 client/WEB-INF/classes/resources/messages_ar.properties 4f65118 client/WEB-INF/classes/resources/messages_es.properties f2d754e client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 ui/dictionary.jsp 671f48f ui/scripts/network.js c27b999 ui/scripts/vpc.js af19d87 Diff: https://reviews.apache.org/r/28043/diff/ Testing (updated) ------- Tests performed: - create new isolated network with DefaultIsolatedNetworkOffering, acquire new IP, list load balancer algorithms (UI) - create new shared network with DefaultSharedNetworkWithSourceNat, acquire new IP, list load balancer algorithms (UI) It should work correctly as long as network offering is configured with LB provider/capabilities. Otherwise, list of algorithms is empty in UI. Thanks, Daniel Vega Simoes --===============7378270066193140720==--