Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DBC4C17879 for ; Mon, 10 Nov 2014 11:44:20 +0000 (UTC) Received: (qmail 39034 invoked by uid 500); 10 Nov 2014 11:44:20 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 38985 invoked by uid 500); 10 Nov 2014 11:44:20 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 38959 invoked by uid 99); 10 Nov 2014 11:44:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Nov 2014 11:44:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5E4201DFDB3; Mon, 10 Nov 2014 11:44:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0133028244515307286==" MIME-Version: 1.0 Subject: Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings From: "Harikrishna Patnala" To: "Kishan Kavala" Cc: "cloudstack" , "Harikrishna Patnala" , "Rohit Yadav" Date: Mon, 10 Nov 2014 11:44:23 -0000 Message-ID: <20141110114423.19819.85609@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Harikrishna Patnala" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/20518/ X-Sender: "Harikrishna Patnala" References: <20140916101733.7803.14301@reviews.apache.org> In-Reply-To: <20140916101733.7803.14301@reviews.apache.org> Reply-To: "Harikrishna Patnala" X-ReviewRequest-Repository: cloudstack-git --===============0133028244515307286== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 16, 2014, 10:17 a.m., Rohit Yadav wrote: > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java, line 4995 > > > > > > Are we using _reserveCpu and _reserveMem in any other place? There are no any references > On Sept. 16, 2014, 10:17 a.m., Rohit Yadav wrote: > > server/src/com/cloud/configuration/Config.java, line 1194 > > > > > > This removes vmware.reserve.mem and vmware.reserve.cpu from global settings, won't this break backward compatibility. We have corresponding objects in vmwareguru. So this won't break anything. This is the way we are following to use ConfigKey interface - Harikrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20518/#review53503 ----------------------------------------------------------- On Nov. 10, 2014, 10:04 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20518/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 10:04 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-6465 > https://issues.apache.org/jira/browse/CLOUDSTACK-6465 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings > > > Diffs > ----- > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4f24882 > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java e3bfbe5 > server/src/com/cloud/configuration/Config.java 5ac0e90 > > Diff: https://reviews.apache.org/r/20518/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > > --===============0133028244515307286==--