Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2B5BA173B7 for ; Mon, 10 Nov 2014 09:33:50 +0000 (UTC) Received: (qmail 83063 invoked by uid 500); 10 Nov 2014 09:33:49 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 83014 invoked by uid 500); 10 Nov 2014 09:33:49 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 82994 invoked by uid 99); 10 Nov 2014 09:33:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Nov 2014 09:33:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B76A21DFDB3; Mon, 10 Nov 2014 09:33:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4767388635385277428==" MIME-Version: 1.0 Subject: Re: Review Request 27652: Normalize error message strings to make maintenance of said strings a bit easier. From: "Rajani Karuturi" To: "Derrick Schneider" , "Rajani Karuturi" , "cloudstack" Date: Mon, 10 Nov 2014 09:33:52 -0000 Message-ID: <20141110093352.19818.6939@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rajani Karuturi" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/27652/ X-Sender: "Rajani Karuturi" References: <20141106004655.10454.12329@reviews.apache.org> In-Reply-To: <20141106004655.10454.12329@reviews.apache.org> Reply-To: "Rajani Karuturi" X-ReviewRequest-Repository: cloudstack-git --===============4767388635385277428== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27652/#review60553 ----------------------------------------------------------- Ship it! Ship It! - Rajani Karuturi On Nov. 6, 2014, 12:46 a.m., Derrick Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27652/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 12:46 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Takes strings that were duplicated within DatabaseUpgradeChecker and puts them into nearby variables. > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java cba6b83 > > Diff: https://reviews.apache.org/r/27652/diff/ > > > Testing > ------- > > As this is just putting an extant value into a variable, I simply did a build to make sure everything was still good. If there's other stuff I can do, please advise. > > > Thanks, > > Derrick Schneider > > --===============4767388635385277428==--