Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C8322179CD for ; Tue, 4 Nov 2014 20:44:24 +0000 (UTC) Received: (qmail 5740 invoked by uid 500); 4 Nov 2014 20:44:23 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 5030 invoked by uid 500); 4 Nov 2014 20:44:22 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 4936 invoked by uid 99); 4 Nov 2014 20:44:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Nov 2014 20:44:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5BA061DFB74; Tue, 4 Nov 2014 20:28:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1686319063730603947==" MIME-Version: 1.0 Subject: Re: Review Request 27527: Fixing previous commit CLOUDSTACK-7720: No IP Address Validation for Acquire new secondary IP From: "Brian Federle" To: "Jessica Wang" , "Jayapal Reddy" , "Brian Federle" Cc: "Gabor Apati-Nagy" , "cloudstack" Date: Tue, 04 Nov 2014 20:28:20 -0000 Message-ID: <20141104202820.10455.11385@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Federle" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/27527/ X-Sender: "Brian Federle" References: <20141103162855.10454.10175@reviews.apache.org> In-Reply-To: <20141103162855.10454.10175@reviews.apache.org> Reply-To: "Brian Federle" X-ReviewRequest-Repository: cloudstack-git --===============1686319063730603947== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27527/#review59824 ----------------------------------------------------------- Ship it! Ship It! - Brian Federle On Nov. 3, 2014, 4:28 p.m., Gabor Apati-Nagy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27527/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 4:28 p.m.) > > > Review request for cloudstack, Brian Federle, Jayapal Reddy, and Jessica Wang. > > > Bugs: CLOUDSTACK-7720 > https://issues.apache.org/jira/browse/CLOUDSTACK-7720 > > > Repository: cloudstack-git > > > Description > ------- > > Fixing Jayapal's finding (see https://issues.apache.org/jira/browse/CLOUDSTACK-7720 ) > Removed required constraint from the IP address field (this is an optional field) > > > Diffs > ----- > > ui/scripts/network.js 278545bff59d247c528283d136eb5b8ec831892c > > Diff: https://reviews.apache.org/r/27527/diff/ > > > Testing > ------- > > > Thanks, > > Gabor Apati-Nagy > > --===============1686319063730603947==--