Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C326177FA for ; Tue, 4 Nov 2014 06:23:49 +0000 (UTC) Received: (qmail 73331 invoked by uid 500); 4 Nov 2014 06:23:49 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 73280 invoked by uid 500); 4 Nov 2014 06:23:49 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 73267 invoked by uid 99); 4 Nov 2014 06:23:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Nov 2014 06:23:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 92CDD1DFB1F; Tue, 4 Nov 2014 06:23:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7962497970461567455==" MIME-Version: 1.0 Subject: Re: Review Request 26438: CLOUDSTACK-7682: Fixed usage event issue. Used api client of account for which we are checking the usage From: "SrikanteswaraRao Talluri" To: "SrikanteswaraRao Talluri" Cc: "Gaurav Aradhye" , "cloudstack" Date: Tue, 04 Nov 2014 06:23:52 -0000 Message-ID: <20141104062352.10454.3255@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "SrikanteswaraRao Talluri" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/26438/ X-Sender: "SrikanteswaraRao Talluri" References: <20141017095126.24426.35808@reviews.apache.org> In-Reply-To: <20141017095126.24426.35808@reviews.apache.org> Reply-To: "SrikanteswaraRao Talluri" X-ReviewRequest-Repository: cloudstack-git --===============7962497970461567455== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26438/#review59746 ----------------------------------------------------------- 883123630c48d0246e811ba0366163fbdbc82010 master - SrikanteswaraRao Talluri On Oct. 17, 2014, 9:51 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26438/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 9:51 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7682 > https://issues.apache.org/jira/browse/CLOUDSTACK-7682 > > > Repository: cloudstack-git > > > Description > ------- > > The events TEMPLATE.CREATE and TEMPLATE.DELETE does not exist in usage event table against that particular account because the template is not created using the api client of the account and hence the template belongs to the root admin account. > > Changes: > Use the api client of the account against which we are checking the usage while creating and deleting the template. > > Have not addressed the pep8 issues already present in the file because that will mask the changes to fix the issue. I will be happy to add a separate patch for it if required. Considering that many files need pep8 fixes, a separate task for this should be created and addressed. > > > Diffs > ----- > > test/integration/component/test_usage.py 81cce48 > > Diff: https://reviews.apache.org/r/26438/diff/ > > > Testing > ------- > > Tested for syntax and import errors. > > > Thanks, > > Gaurav Aradhye > > --===============7962497970461567455==--