cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wido den Hollander <w...@widodh.nl>
Subject Re: Strange if else under LibvirtStorageAdaptor.java[lines 1203-1206]
Date Mon, 03 Nov 2014 10:27:49 GMT


On 11/03/2014 10:05 AM, Santhosh Edukulla wrote:
> Team,
> 
> Either of the paths are doing the same thing for below if else, please check. This is
observed under master.
> 

I think that is a weird merge thing somewhere. I don't see any reason
why this if statement is there.

Wido

>  if (srcPool.getType() != StoragePoolType.RBD) {
>                     newDisk = destPool.createPhysicalDisk(name, Storage.ProvisioningType.THIN,
disk.getVirtualSize());
>                 } else {
>                     newDisk = destPool.createPhysicalDisk(name, Storage.ProvisioningType.THIN,
disk.getVirtualSize());
>                 }
> 
> Santhosh
> 

Mime
View raw message