cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "tian chunfeng" <chunf...@domolo.com>
Subject Review Request 28535: core project can not pass junit test on mac platform .
Date Sat, 29 Nov 2014 09:22:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28535/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

run test on core failed : Change firewall rule set from HashSet to TreeSet because HashSet
elements are not ordered , which will cause test failed when  elements toArray are not same
between windows and mac . 


Diffs
-----

  core/src/com/cloud/agent/api/routing/SetFirewallRulesCommand.java be85887 

Diff: https://reviews.apache.org/r/28535/diff/


Testing
-------

after ensure the firewall rule set in TreeSet , toArray will the same order accross windows
and mac platform, and passed test.


Thanks,

tian chunfeng


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message