cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request 25585: [CLOUDSTACK-2823] SystemVMs start fail on CentOS 6.4
Date Thu, 27 Nov 2014 11:27:37 GMT


> On Nov. 27, 2014, 11:26 a.m., Rohit Yadav wrote:
> > Thanks for your contribution. It failed for me on 4.3, but I manually fixed it and
committed on 4.3 branch.
> > Please consider using Github Pull Request in future as they are less painful for
many of us helping with reviews and merging patches back to ACS branches.
> > 
> > commit 0a935a336ebf9dcc1c3b25a56f629bb9a217b56f
> > Author: David Bierce <david.bierce@appcore.com>
> > Date:   Thu Nov 27 16:50:51 2014 +0530
> > 
> >     CLOUDSTACK-2823: Loop through cmdline when patching routers
> >     
> >     Backported from https://reviews.apache.org/r/25585/diff which did not merge
> >     this fix on 4.3 branch. Occasionally the while loop can exit with no data (Probably
> >      recieving an EOF) before receiveing CMDline data from the certial port.
> >     Continue looping until cmdline is populated
> >     
> >     Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

On 4.4;
commit 9d7624f6acac104415ae64d7c7126b5771141d8e
Author: David Bierce <david.bierce@appcore.com>
Date:   Fri Sep 12 10:52:29 2014 -0500

    Occasionally the while loop can exit with no data (Probably recieving an EOF) before receiveing
CMDline data from the certial port. Continue looping until cmdline is populated
    
    Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25585/#review63207
-----------------------------------------------------------


On Sept. 13, 2014, 1:01 a.m., David Bierce wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25585/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 1:01 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> SystemVMs start fail on CentOS 6
> 
> 
> Diffs
> -----
> 
>   systemvm/patches/debian/config/etc/init.d/cloud-early-config 9152df2 
> 
> Diff: https://reviews.apache.org/r/25585/diff/
> 
> 
> Testing
> -------
> 
> Code patch applied to Systemvm.iso and cloud-early inside the systemvm template.  Routers
start consitently after patched.
> 
> Tested against cloudstack 4.2.1
> Centos 6.4
> 
> Patch is against 4.3 since 4.2+ is effected by the issue.
> 
> 
> File Attachments
> ----------------
> 
> Updated Patch which includes a sleep
>   https://reviews.apache.org/media/uploaded/files/2014/09/13/c612e257-c83e-4a8e-8970-44d078838db6__patch.diff
> 
> 
> Thanks,
> 
> David Bierce
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message