cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajani Karuturi" <raj...@apache.org>
Subject Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
Date Tue, 25 Nov 2014 08:14:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28049/#review62950
-----------------------------------------------------------

Ship it!


Ship It!

- Rajani Karuturi


On Nov. 24, 2014, 4:23 p.m., Daniel Vega Simoes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28049/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 4:23 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917
> Validate Load Balancer rule with provider before commiting to DB and applying new rule.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 
>   server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28049/diff/
> 
> 
> Testing
> -------
> 
> Created 2 new unit tests that are located in server/test/com/cloud/network/lb/UpdateLoadBalancerTest.java
>   - Test to guarantee that validate is being called when updating LB rule
>   - Test to guarantee that it throws exception if LB rule is not validated by provider
> 
> Ran integration tests (smoke), all seems OK.
> 
> 
> Thanks,
> 
> Daniel Vega Simoes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message