cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilia Shakitko" <i.shaki...@tech.leaseweb.com>
Subject Re: Review Request 27979: CLOUDSTACK-7903: Decrease minimal usage aggregation range value
Date Tue, 25 Nov 2014 07:25:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27979/
-----------------------------------------------------------

(Updated Nov. 25, 2014, 7:25 a.m.)


Review request for cloudstack, Chip Childers, Kishan Kavala, Rohit Yadav, Simon Fiddaman,
Stephen Hoogendijk, and Wei Zhou.


Bugs: CLOUDSTACK-7903
    https://issues.apache.org/jira/browse/CLOUDSTACK-7903


Repository: cloudstack-git


Description
-------

When you want to build 95-percentile billing model for the network traffic usage, it is good
to have 5-minutes (or 1-minute) usage samples instead of 10 (which is minimum allowed in ACS
at the moment). Let admin to control it.
This change decreases the lower limit for USAGE_AGGREGATION_RANGE_MIN parameter, making it
minimum possible positive integer. It is also removes declaration of the same constant in
3 places.

Will be happy if patch can be:
- cherry-picked to the 4.4 and 4.5 branches
- included to the 4.4.2 tag.


Diffs
-----

  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 23ddfb1 
  server/src/com/cloud/server/StatsCollector.java 1fcaa62 
  usage/src/com/cloud/usage/UsageManagerImpl.java fe7ee1e 

Diff: https://reviews.apache.org/r/27979/diff/


Testing
-------

Tested on master, 4.4 and 4.5 branches. But then during the review time I had to re-prepare
the patch and it become compatible only for master branch.

If you accept the patch, could you also cherry-pick my commit to 4.4 and 4.5 branches? (there
will be 1 one-line conflict to resolve)


Thanks,

Ilia Shakitko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message