cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Vega Simoes" <>
Subject Re: Review Request 28049: CLOUDSTACK-7917: Load Balancer Rule is not validated when updating LB
Date Mon, 24 Nov 2014 16:23:30 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 24, 2014, 4:23 p.m.)

Review request for cloudstack.


Updated diff to include 2 new unit tests

Repository: cloudstack-git


Validate Load Balancer rule with provider before commiting to DB and applying new rule.

Diffs (updated)

  server/src/com/cloud/network/lb/ a28d108 
  server/test/com/cloud/network/lb/ PRE-CREATION 


Testing (updated)

Created 2 new unit tests that are located in server/test/com/cloud/network/lb/
  - Test to guarantee that validate is being called when updating LB rule
  - Test to guarantee that it throws exception if LB rule is not validated by provider

Ran integration tests (smoke), all seems OK.


Daniel Vega Simoes

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message