cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-7932: Fixed wrong semantics fo...
Date Tue, 18 Nov 2014 07:11:16 GMT
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/39#issuecomment-63430873
  
    In the second return statement, should it return false since the agent is alive and returned
some status?
    
    I didnt understand the argument for not adding unittests. I see that as an only way to
avoid the same changes in future as findbugs would report it again and someone would attempt
to fix it again. 
    adding some documentation might help.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message