cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-7932: Fixed wrong semantics fo...
Date Tue, 18 Nov 2014 06:33:36 GMT
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/39#issuecomment-63428603
  
    From the method definition (isVmAlive), looks like what it is doing is right. 
    ideally, we should change the return type from Boolean to boolean in the interface. 
    
    Maybe in the caller(HighAvailabilityManagerImpl), you could check for both null and false
for now. 
    
    Also, can you add some unittests? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message