cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Vega Simoes" <>
Subject Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI
Date Mon, 17 Nov 2014 18:26:01 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 17, 2014, 6:26 p.m.)

Review request for cloudstack.


- as suggested by Rajani Karuturi, created a new function in network.js to list LB algorithms
for a network.
- fixed internationalization for 'label.source'
- updated to use last commit on master (efe47b07044a863e5a34f48ef6e2468265925604)

Repository: cloudstack-git



Removed hard-coded values for Load Balancer algorithms in UI. 

Instead, now UI sets values loaded dynamically through load balancer provider capabilities.

Also updated internationalization messages.

Diffs (updated)

  client/WEB-INF/classes/resources/ 86eb5c2 
  client/WEB-INF/classes/resources/ 4f65118 
  client/WEB-INF/classes/resources/ f2d754e 
  client/WEB-INF/classes/resources/ 004187f 
  client/WEB-INF/classes/resources/ e2f3f0b 
  client/WEB-INF/classes/resources/ 7bc90b5 
  client/WEB-INF/classes/resources/ ce79d2e 
  client/WEB-INF/classes/resources/ c169112 
  client/WEB-INF/classes/resources/ 89ef828 
  client/WEB-INF/classes/resources/ 06d5ec2 
  client/WEB-INF/classes/resources/ 8ee08ba 
  client/WEB-INF/classes/resources/ ff68668 
  client/WEB-INF/classes/resources/ ebba5e0 
  ui/dictionary.jsp 671f48f 
  ui/scripts/network.js c27b999 
  ui/scripts/vpc.js af19d87 


Testing (updated)

Tests performed:
- create new isolated network with DefaultIsolatedNetworkOffering, acquire new IP, list load
balancer algorithms (UI)
- create new shared network with DefaultSharedNetworkWithSourceNat, acquire new IP, list load
balancer algorithms (UI)

It should work correctly as long as network offering is configured with LB provider/capabilities.
Otherwise, list of algorithms is empty in UI.


Daniel Vega Simoes

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message