cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 27883: CLOUDSTACK-7885 - Fixed the script "/maint/test_vpc_host_maintenance.py" - Router will not get automatically Started due to Host maintenance operations
Date Fri, 14 Nov 2014 11:16:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27883/#review61423
-----------------------------------------------------------


Looks good.

- SrikanteswaraRao Talluri


On Nov. 14, 2014, 6:37 a.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27883/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2014, 6:37 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7885
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7885
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> I see that Router is stopped consciously in the setup() method in the test suite. The
test cases check if the Router is in Running state. I checked with Sheng and he mentioned
that a Stopped Router will not get automatically started due Host Maintenance Use Cases. Hence
stop command should be removed from the setup() Method.
> 
> As a fix, I removed the stop command from setup() method
> 
> I fixed the enable and cancel maintenance mode test cases to work properly in the test
suite
> 
> 
> Diffs
> -----
> 
>   test/integration/component/maint/test_vpc_host_maintenance.py fbc1bb4 
> 
> Diff: https://reviews.apache.org/r/27883/diff/
> 
> 
> Testing
> -------
> 
> Test enable Maintenance Mode on Hosts which have VPC elements ... === TestName: test_01_enable_maintenance_with_vpc_nw
| Status : SUCCESS ===
> ok
> Test cancel Maintenance Mode on the above Hosts + Migrate VMs Back ... === TestName:
test_02_cancel_maintenance | Status : SUCCESS ===
> ok
> Test reconnect Host which has VPC elements ... === TestName: test_03_reconnect_host |
Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 3 tests in 463.515s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message