cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Fiddaman" <si...@fiddaman.nl>
Subject Re: Review Request 27979: CLOUDSTACK-7903: Decrease minimal usage aggregation range value
Date Thu, 13 Nov 2014 13:37:52 GMT


> On Nov. 13, 2014, 10:11 a.m., Rohit Yadav wrote:
> > I've added Kishan to this as well. Though it looks good and we can surely accept
it. I think it makes sense to either set it to 1 or have a global configuration added which
makes it easy for sysadmins to set a value they want instead of hard coding it.

This request is to change the minimum value that another (already configurable) value can
be set to. Why not simply enforce USAGE_AGGREGATION_RANGE to integer type and abolish the
USAGE_AGGREGATION_RANGE_MIN parameter (thus the minimum value for USAGE_AGGREGATION_RANGE
is 1)? A note could even be added to the USAGE_AGGREGATION_RANGE configuration entry point
stating this will result in 1440/USAGE_AGGREGATION_RANGE usage records per day entered in
the Usage DB for each Network.


- Simon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27979/#review61224
-----------------------------------------------------------


On Nov. 13, 2014, 10:09 a.m., Ilia Shakitko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27979/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2014, 10:09 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Rohit Yadav, and Wei Zhou.
> 
> 
> Bugs: CLOUDSTACK-7903
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7903
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When you want to build 95-percentile billing model for the network traffic usage, it
is good to have 5-minutes usage samples instead of 10 (which is minimum allowed in ACS at
the moment).
> This change decreases the lower limit for USAGE_AGGREGATION_RANGE_MIN parameter.
> 
> Will be happy if patch can be included to the 4.4.2 tag.
> 
> 
> Diffs
> -----
> 
>   usage/src/com/cloud/usage/UsageManagerImpl.java fe7ee1e 
> 
> Diff: https://reviews.apache.org/r/27979/diff/
> 
> 
> Testing
> -------
> 
> Tested on both 4.4 and master branches.
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message