cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harikrishna Patnala" <harikrishna.patn...@citrix.com>
Subject Re: Review Request 20518: CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
Date Mon, 10 Nov 2014 11:44:23 GMT


> On Sept. 16, 2014, 10:17 a.m., Rohit Yadav wrote:
> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java,
line 4995
> > <https://reviews.apache.org/r/20518/diff/1/?file=563053#file563053line4995>
> >
> >     Are we using _reserveCpu and _reserveMem in any other place?

There are no any references


> On Sept. 16, 2014, 10:17 a.m., Rohit Yadav wrote:
> > server/src/com/cloud/configuration/Config.java, line 1194
> > <https://reviews.apache.org/r/20518/diff/1/?file=563054#file563054line1194>
> >
> >     This removes vmware.reserve.mem and vmware.reserve.cpu from global settings,
won't this break backward compatibility.

We have corresponding objects in vmwareguru. So this won't break anything. 
This is the way we are following to use ConfigKey interface


- Harikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20518/#review53503
-----------------------------------------------------------


On Nov. 10, 2014, 10:04 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20518/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 10:04 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-6465
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6465
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings 
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 7c23699 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
4f24882 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
e3bfbe5 
>   server/src/com/cloud/configuration/Config.java 5ac0e90 
> 
> Diff: https://reviews.apache.org/r/20518/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message