cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajani Karuturi" <raj...@apache.org>
Subject Re: Review Request 27652: Normalize error message strings to make maintenance of said strings a bit easier.
Date Thu, 06 Nov 2014 04:49:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27652/#review60111
-----------------------------------------------------------


looking at the diff isnt giving me much information. Can you share what issues it is solving(a
JIRA ticket?)? Is this related to internationalizing the strings?

- Rajani Karuturi


On Nov. 6, 2014, 12:46 a.m., Derrick Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27652/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 12:46 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Takes strings that were duplicated within DatabaseUpgradeChecker and puts them into nearby
variables.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java cba6b83 
> 
> Diff: https://reviews.apache.org/r/27652/diff/
> 
> 
> Testing
> -------
> 
> As this is just putting an extant value into a variable, I simply did a build to make
sure everything was still good. If there's other stuff I can do, please advise.
> 
> 
> Thanks,
> 
> Derrick Schneider
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message