cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 26438: CLOUDSTACK-7682: Fixed usage event issue. Used api client of account for which we are checking the usage
Date Tue, 04 Nov 2014 06:23:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26438/#review59746
-----------------------------------------------------------


883123630c48d0246e811ba0366163fbdbc82010 master

- SrikanteswaraRao Talluri


On Oct. 17, 2014, 9:51 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26438/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 9:51 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7682
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7682
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The events TEMPLATE.CREATE and TEMPLATE.DELETE does not exist in usage event table against
that particular account because the template is not created using the api client of the account
and hence the template belongs to the root admin account.
> 
> Changes:
> Use the api client of the account against which we are checking the usage while creating
and deleting the template.
> 
> Have not addressed the pep8 issues already present in the file because that will mask
the changes to fix the issue. I will be happy to add a separate patch for it if required.
Considering that many files need pep8 fixes, a separate task for this should be created and
addressed.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_usage.py 81cce48 
> 
> Diff: https://reviews.apache.org/r/26438/diff/
> 
> 
> Testing
> -------
> 
> Tested for syntax and import errors.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message