cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilia Shakitko <i.shaki...@tech.leaseweb.com>
Subject RE: Review Request 27979: CLOUDSTACK-7903: Decrease minimal usage aggregation range value
Date Tue, 18 Nov 2014 13:47:51 GMT
Hi Rohit,

It's a week almost w/o an answer from Kishan. Meanwhile, I've redone the patch, removing some
duplications (found 2 more places with same constant declared). And decreased the limit to
1 (minimal logical range limit). So it was a good feedback from you and Simon to actually
let admins to decide. Maybe I don't need less than 5, but someone will need 1 or 2.

Could you please review it? Would be also cool to apply it to 4.4 and 4.5 (I wrote a remark
in the review).


Kind regards,

Ilia Shakitko
Innovation Engineer
LeaseWeb Technologies B.V.

T: +31 20 316 0235
M:
E: i.shakitko@tech.leaseweb.com
W: http://www.leaseweb.com

Luttenbergweg 8, 1101 EC Amsterdam, Netherlands


-----Original Message-----
From: Rohit Yadav [mailto:noreply@reviews.apache.org] On Behalf Of Rohit Yadav
Sent: donderdag, 13 november, 2014 11:11
To: Kishan Kavala; Wei Zhou; Rohit Yadav
Cc: Ilia Shakitko; cloudstack
Subject: Re: Review Request 27979: CLOUDSTACK-7903: Decrease minimal usage aggregation range
value


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27979/#review61224
-----------------------------------------------------------


I've added Kishan to this as well. Though it looks good and we can surely accept it. I think
it makes sense to either set it to 1 or have a global configuration added which makes it easy
for sysadmins to set a value they want instead of hard coding it.

- Rohit Yadav


On Nov. 13, 2014, 10:09 a.m., Ilia Shakitko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27979/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 10:09 a.m.)
>
>
> Review request for cloudstack, Kishan Kavala, Rohit Yadav, and Wei Zhou.
>
>
> Bugs: CLOUDSTACK-7903
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7903
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When you want to build 95-percentile billing model for the network traffic usage, it
is good to have 5-minutes usage samples instead of 10 (which is minimum allowed in ACS at
the moment).
> This change decreases the lower limit for USAGE_AGGREGATION_RANGE_MIN parameter.
>
> Will be happy if patch can be included to the 4.4.2 tag.
>
>
> Diffs
> -----
>
>   usage/src/com/cloud/usage/UsageManagerImpl.java fe7ee1e
>
> Diff: https://reviews.apache.org/r/27979/diff/
>
>
> Testing
> -------
>
> Tested on both 4.4 and master branches.
>
>
> Thanks,
>
> Ilia Shakitko
>
>

Mime
View raw message