Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 231C11746B for ; Mon, 27 Oct 2014 06:41:04 +0000 (UTC) Received: (qmail 27667 invoked by uid 500); 27 Oct 2014 06:40:53 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 27599 invoked by uid 500); 27 Oct 2014 06:40:53 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 27587 invoked by uid 99); 27 Oct 2014 06:40:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Oct 2014 06:40:53 +0000 X-ASF-Spam-Status: No, hits=0.6 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [74.125.149.238] (HELO na3sys009aog115.obsmtp.com) (74.125.149.238) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Oct 2014 06:40:26 +0000 Received: from mail-ie0-f175.google.com ([209.85.223.175]) (using TLSv1) by na3sys009aob115.postini.com ([74.125.148.12]) with SMTP ID DSNKVE3oZ0TGfibiNh5IEbKi48HTTCYWY54B@postini.com; Sun, 26 Oct 2014 23:40:25 PDT Received: by mail-ie0-f175.google.com with SMTP id at20so3764248iec.34 for ; Sun, 26 Oct 2014 23:38:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=iz0uTLmUpmI9mQuNzK8Ar+Y0jt9zr3ovfn54Txux98U=; b=jJLtEvINWcjNTPEDufN90pXt2vx2eRCS5J9H52fgDqzOocZAuWn+exlsNf0DdGsnmK JdhnTUHnFaGnoRYqtk7ECCDxRT6FZjWsQN9pM/KaXjbYfm5EQdT3UfpwQJ/MvAiWbIJh KKAHqasAT9OwKdKJIoV2aEKYojxVIlITPfMKSOPRBi/E8+gJkS7FYrX09XZUEMv2/csp UQ27G4j0gARg4FzN5tDTEZuWmooit/+9N3r0seIB3ZCRk7ov8R5c+QuxZKJ46sNtlmox sib2hyGktUIfccrrjnjfO4LQwHRPgzfapIIdpD7kJvnhXJPOe4dDeobQtPV0m2De3zLz Yntw== X-Received: by 10.50.110.4 with SMTP id hw4mr19918452igb.14.1414391911669; Sun, 26 Oct 2014 23:38:31 -0700 (PDT) X-Gm-Message-State: ALoCoQmfTkyHyAAd2RIdqD6qP4oRomUGmqprOf9KBdjhY11q7s5fxFLhnQHKm36BZamcMpFAW3MpWbZZ9Yhxhe0a/x2LKKeAdvw3NvOcP79W1Kg4a27k3NT6kZOKLPhwdBnAFXI/jLoggSMfyWIJOaNtCQEfDa6p+g== MIME-Version: 1.0 X-Received: by 10.50.110.4 with SMTP id hw4mr19918440igb.14.1414391911484; Sun, 26 Oct 2014 23:38:31 -0700 (PDT) Received: by 10.107.25.200 with HTTP; Sun, 26 Oct 2014 23:38:31 -0700 (PDT) In-Reply-To: References: <20140818095417.7621.47803@reviews.apache.org> Date: Mon, 27 Oct 2014 12:08:31 +0530 Message-ID: Subject: Re: Review Request 24794: Review request for CLOUDSTACK-6169 - assignVirtualMachine leaves associated tags assigned to old account From: Namita Chaudhari To: Marcus Cc: cloudstack Content-Type: multipart/related; boundary=089e013cb812756354050661c79d X-Virus-Checked: Checked by ClamAV on apache.org --089e013cb812756354050661c79d Content-Type: multipart/alternative; boundary=089e013cb812756352050661c79c --089e013cb812756352050661c79c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Gentle reminder for code review.. @Marcus, Please ignore this reminder.. Thanks and Regards, Namita Chaudhari On Thu, Sep 4, 2014 at 10:31 PM, Marcus wrote: > As I mentioned, I'm probably the wrong person to review this fix, though = I > did record the bug. If someone. If someone has domain knowledge in this > particular area please take a look. > On Sep 4, 2014 12:17 AM, "Namita Chaudhari" < > namita.chaudhari@sungardas.com> wrote: > >> Gentle reminder.. >> >> >> On Mon, Aug 18, 2014 at 3:24 PM, Namita Chaudhari < >> namita.chaudhari@sungard.com> wrote: >> >>> >>> ----------------------------------------------------------- >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/24794/ >>> ----------------------------------------------------------- >>> >>> Review request for cloudstack and Marcus Sorensen. >>> >>> >>> Bugs: CLOUDSTACK-6169 and >>> https://issues.apache.org/jira/browse/CLOUDSTACK-6169 >>> https://issues.apache.org/jira/browse/CLOUDSTACK-6169 >>> >>> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/br= owse/CLOUDSTACK-6169 >>> >>> >>> Repository: cloudstack-git >>> >>> >>> Description >>> ------- >>> >>> CLOUDSTACK-6169 - assignVirtualMachine leaves associated tags assigned >>> to old account >>> >>> When a VM is assigned from one account to another, the tags associated >>> to the VM points to the new account and not old one. >>> >>> >>> Diffs >>> ----- >>> >>> engine/schema/src/com/cloud/tags/ResourceTagVO.java eadddd1 >>> engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java fffe2a47 >>> engine/schema/src/com/cloud/tags/dao/ResourceTagsDaoImpl.java 3611999 >>> server/src/com/cloud/vm/UserVmManagerImpl.java e5de11f >>> >>> Diff: https://reviews.apache.org/r/24794/diff/ >>> >>> >>> Testing >>> ------- >>> >>> Yes. >>> >>> >>> Thanks, >>> >>> Namita Chaudhari >>> >>> >> >> >> -- >> >> *Namita Chaudhari* =E2=97=8F Engineer - Product Development =E2=97=8F Su= nGard >> Availability Services, India. =E2=97=8F 2nd Floor, Wing 4, Cluster D, MI= DC >> Kharadi Knowledge Park, Pune - 411 014 =E2=97=8F Email: >> namita.chaudhari@sungardas.com =E2=97=8F >> www.sungardas.in >> >> >> >> [image: Description: cid:image019.png@01CF48EC.6617C7F0] [image: >> Description: cid:image020.png@01CF48EC.6617C7F0] [image: Description: >> cid:image021.png@01CF48EC.6617C7F0] [image: Description: >> cid:image022.png@01CF48EC.6617C7F0] [image: Description: >> cid:image023.png@01CF48EC.6617C7F0] [image: Description: >> cid:image024.png@01CF48EC.6617C7F0] >> >> --=20 *Namita Chaudhari* =E2=97=8F Engineer - Product Development =E2=97=8F SunGa= rd Availability Services, India. =E2=97=8F 2nd Floor, Wing 4, Cluster D, MIDC Kharadi Knowl= edge Park, Pune - 411 014 =E2=97=8F Email: namita.chaudhari@sungardas.com =E2=97=8F www.sungardas.in [image: Description: cid:image019.png@01CF48EC.6617C7F0] [image: Description: cid:image020.png@01CF48EC.6617C7F0] [image: Description: cid:image021.png@01CF48EC.6617C7F0] [image: Description: cid:image022.png@01CF48EC.6617C7F0] [image: Description: cid:image023.png@01CF48EC.6617C7F0] [image: Description: cid:image024.png@01CF48EC.6617C7F0] --089e013cb812756352050661c79c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Gentle reminder for code review..

= @Marcus,
Please ignore this reminder..


Thanks and Regards,
Namita Chaudhari

On Thu, Sep 4, 2014 at 10:31 P= M, Marcus <shadowsor@gmail.com> wrote:

As I mentioned, I'm probably the wrong pe= rson to review this fix, though I did record the bug. If someone. If someon= e has domain knowledge in this particular area please take a look.

On Sep 4, 2014 12:17 AM, "Namita Chaudhari&= quot; <namita.chaudhari@sungardas.com> wrote:
Gentle reminder..=


On Mon, Aug 18, 2014 at 3:24 PM, Namita Chaudhari <= namita.ch= audhari@sungard.com> wrote:

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://r= eviews.apache.org/r/24794/
-----------------------------------------------------------

Review request for cloudstack and Marcus Sorensen.


Bugs: CLOUDSTACK-6169 and https://issues.apache.org/jira/browse/CL= OUDSTACK-6169
=C2=A0 =C2=A0 https://issues.apache.org/jira/browse/CLOUDSTACK-616= 9
=C2=A0 =C2=A0 https://issues= .apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-61= 69


Repository: cloudstack-git


Description
-------

CLOUDSTACK-6169 - assignVirtualMachine leaves associated tags assigned to o= ld account

When a VM is assigned from one account to another, the tags associated to t= he VM points to the new account and not old one.


Diffs
-----

=C2=A0 engine/schema/src/com/cloud/tags/ResourceTagVO.java eadddd1
=C2=A0 engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java fffe2a47 =C2=A0 engine/schema/src/com/cloud/tags/dao/ResourceTagsDaoImpl.java 361199= 9
=C2=A0 server/src/com/cloud/vm/UserVmManagerImpl.java e5de11f

Diff: https://reviews.apache.org/r/24794/diff/


Testing
-------

Yes.


Thanks,

Namita Chaudhari




--

Namita Chaudhari= =C2=A0=E2=97=8F Engineer -= Product Development=C2=A0=E2=97=8F=C2=A0SunGard Availability Servi= ces, India.=C2=A0=E2=97=8F=C2=A02nd Floor, Wing 4, Cluster D, MIDC = Kharadi Knowledge Park, Pune - 411 014=C2=A0=E2=97=8F Email:=C2=A0namita.chaudhari@sungardas.com=C2=A0=E2=97=8F= =C2=A0www.sungardas.i= n

=C2=A0

3D"Description:=C2=A0=C2=A03D"Description:=C2=A0= =C2=A03D"Description:=C2=A0=C2=A03D"Description:=C2= =A0=C2=A03D"Description:=C2= =A0=C2=A03D"Description:=C2=A0




--
=

Namita Chaudhari=C2=A0=E2=97=8F = Engineer - Product Development=C2=A0=E2= =97=8F=C2=A0SunGard Availa= bility Services, India.=C2=A0=E2=97=8F=C2=A02nd Floor, Wing 4, Clus= ter D, MIDC Kharadi Knowledge Park, Pune - 411 014=C2=A0=E2=97=8F Email:=C2=A0namita.chaudhari@sungardas.com= =C2=A0=E2=97=8F=C2=A0www= .sungardas.in

=C2=A0

3D"Description:=C2=A0=C2=A03D"Description:=C2=A0=C2=A03D"Description:=C2=A0=C2=A03D"Description:=C2=A0=C2=A03D"Description:=C2=A0=C2=A0=3D"Description:=C2=A0

--089e013cb812756352050661c79c-- --089e013cb812756354050661c79d--