Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <5444E5C8.6020508@widodh.nl>
Date: Mon, 20 Oct 2014 12:36:56 +0200
From: Wido den Hollander <wido@widodh.nl>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: dev@cloudstack.apache.org
Subject: Re: [PROPOSAL] Move to github PR only during moratorium on commit
References: <5D7C3B65-4B76-4B8B-B22C-F5CF1AF8846A@gmail.com>
In-Reply-To: <5D7C3B65-4B76-4B8B-B22C-F5CF1AF8846A@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/18/2014 11:00 AM, sebgoa wrote:
> After [1] I would like to officially bring up the following
> proposal.
> 
> [Proposal] ---- All commits come through github PR, *even* for
> committers. We declare a moratorium period (agreed suspension of
> activity) during which direct commit to master is forbidden. Only
> the master RM is allowed to merge PR in master (we define a master
> RM). If direct commit to master is done, master RM reverts without
> warning. Same for 4.5 and 4.4. branches. ----
> 
> This is drastic and I am sure some folks will not like it, but here
> is my justification for such a measure:
> 

I fully understand the reasoning and I agree that this is the best way
forward.

Code quality is much more needed then new features. Revert without
warning is also just fine.

It will take some time to adjust, but this would be a great thing to do.

Wido

> [Reasons]: ---- Our commit and release processes have so far been
> based on the idea that development happens on master and that a
> release branch is cut from master (unstable development branch).
> Then a different set of community members harden the release
> branch, QA and bring it to GA level. During that time development
> keeps on going in master.
> 
> This is an OK process if we have the luxury of having a QA team and
> can cope with split personality of being developers and release
> managers.
> 
> My point of view is that as a community we cannot afford such a
> split brain organization and our experience overt the last year
> proves my point (delayed release date, broken builds, features
> merged without warning�)
> 
> We can avoid this by cutting a release branch from a stable one
> (from the start), then as you (Daan) have mentioned several times,
> fix bugs in the release branch and merge them back in the stable
> source of the release (be it master).
> 
> Feature development need to be done outside master, period. Not
> only for non-committers but also for committers. And merge request
> need to be called. This will help review and avoid surprises.
> 
> New git workflow were proposed and shutdown, mostly calling for
> better CI to solve quality issues. CI will not solve our quality
> issues alone. We need to better police ourselves.
> 
> To avoid long discussions, I propose this simple but drastic
> measure. We move all our commits to github PR until 4.5 is out,
> this stands for committers and non-committers, direct commits
> (especially to master) would be reverted immediately. ----
> 
> Our development and release process is broken, we cannot continue
> like this, let's fix it.
> 
> [1] http://markmail.org/thread/xeliefp3oleq3g54
> 
> -sebastien
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJUROXIAAoJEAGbWC3bPspCifwP/1NtM7L61p8YI/W4qn9LH+fs
oo5PeLY61IitdDGJoT7DTfiJhCgM4HWYHKyZOUkZLm53wUKbrUuzSVZ6ZIfrlss6
erWIXCHrk2VPzaBX3nyOBzaEdrnLYTlMdJgxHVd5IUq+HBtf3GPQDUHu3EnsNKk4
BP+3fJg5hfIF4jkevXlGebcdsT9CWQIz3Z656Dr1tknYUBlTyM+wBOsp3BhAEWG0
VTC9Gt/YfOo3P3xWEBUZ40GRhd4bM9OaHhiDqN/vz4wKyz7X2//oShudVSTZsrg9
Hm2CYt9W1/TjLEAk87VBvtNyY4U9OaZTnQBK/T+N7uu7E8whFmqffDDWYiSmBt+J
UDsYQfn/U/aKqgyMasXRWTF8CxZHRM8YyZzwbrMhVYUPdlsnhUdmzksG7zKwcNjp
rpXcS3LkXW6xp0sYp6MWdUp7EVhpDE7q06HiWDONrrKRdyKTxO9P+tWWUJJdVee/
zwb617SIFyDYK9DBKSDSGIdAFE81rl+PBTqPJe2wotJ5KKuRbcVWaqFqvWqmuLxs
XiMiB3CduBbLecmyEqa0szQqv9OXRHeNGvrjEM29L7kYSb6Rua05jmTwFXEj+1Ob
IxF9wOB/licwfCOE8VSNz8xbiptbtloKhT4OFyliFW/RAuBwQlznus8A9xGVgYz1
gCnEIljSR6Tle3F9kvU7
=MHeW
-----END PGP SIGNATURE-----