Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============0635540555526490464=="
MIME-Version: 1.0
Subject: Re: Review Request 27269: CLOUDSTACK-7800: VMware - Hot plug/unplug
 NIC
 to/from VM only when vmware tools are installed, else assert for exception
From: "SrikanteswaraRao Talluri" <srikanteswararao.talluri@citrix.com>
To: "Raj Kumar" <rajkumar.mardubudi@gmail.com>,
 "SrikanteswaraRao Talluri" <srikanteswararao.talluri@citrix.com>
Cc: "Gaurav Aradhye" <gaurav.aradhye@clogeny.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Wed, 29 Oct 2014 09:46:02 -0000
Message-ID: <20141029094602.7137.88051@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "SrikanteswaraRao Talluri" <noreply@reviews.apache.org>
References: <20141029015517.7143.53731@reviews.apache.org>
In-Reply-To: <20141029015517.7143.53731@reviews.apache.org>
Reply-To: "SrikanteswaraRao Talluri" <srikanteswararao.talluri@citrix.com>

--===============0635540555526490464==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27269/#review58972
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Oct. 29, 2014, 1:55 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27269/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 1:55 a.m.)
> 
> 
> Review request for cloudstack, Raj Kumar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7800
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7800
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Starting vCenter 5.5 it has been made strict that hot unplug requires vmware tools installed on the guest os.
> 
> VMware will report error if the vmtools are not installed.
> 
> The tests that are trying hot plug and unplug of nic on vms running on vmware, must check for vmware tools running on the vm.
> if the vm does not have tools => assert true for the exception.
> if vm has vm tools running => Then only try for plug/unplug of nic.
> 
> In case of any other hypervisor, test suite will perform all the steps as it is.
> 
> 
> Other changes:
> 1. Pep8 fixes
> 2. Changing from import * to specific imports
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_nic.py 488ed0a 
> 
> Diff: https://reviews.apache.org/r/27269/diff/
> 
> 
> Testing
> -------
> 
> Tested with vmware tools not installed on VM scenario. (KVM and Vmware)
> I could not get the tools installed on VM.
> 
> Log:
> Test to add and update added nic to a virtual machine ... === TestName: test_01_nic | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 304.106s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


--===============0635540555526490464==--