Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 319D4175C1 for ; Fri, 17 Oct 2014 17:41:21 +0000 (UTC) Received: (qmail 44040 invoked by uid 500); 17 Oct 2014 17:41:20 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 43991 invoked by uid 500); 17 Oct 2014 17:41:20 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 43973 invoked by uid 99); 17 Oct 2014 17:41:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Oct 2014 17:41:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C709C1DF41B; Fri, 17 Oct 2014 17:41:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9134152384253876286==" MIME-Version: 1.0 Subject: Re: Review Request 26871: CLOUDSTACK-7748: Cloudstack version number is missing in system vm template. From: "Nitin Mehta" To: "Kishan Kavala" , "SrikanteswaraRao Talluri" Cc: "Harikrishna Patnala" , "Nitin Mehta" , "cloudstack" Date: Fri, 17 Oct 2014 17:41:15 -0000 Message-ID: <20141017174115.30953.91694@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Nitin Mehta" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/26871/ X-Sender: "Nitin Mehta" References: <20141017173008.30984.30398@reviews.apache.org> In-Reply-To: <20141017173008.30984.30398@reviews.apache.org> Reply-To: "Nitin Mehta" X-ReviewRequest-Repository: cloudstack-git --===============9134152384253876286== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26871/#review57173 ----------------------------------------------------------- tools/appliance/build.sh Why should version be optional at all ? 1. I think it should be mandatory. 2. I would like you to do a more harder check on version making sure it is in correct format as per expectations say it should be > 1.0 and less than say 10.0 < it should be an integer etc. - Nitin Mehta On Oct. 17, 2014, 5:30 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26871/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 5:30 p.m.) > > > Review request for cloudstack, Kishan Kavala and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7748 > https://issues.apache.org/jira/browse/CLOUDSTACK-7748 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-7748: Cloudstack version number is missing in system vm template. > /etc/cloudstack-release in system vm does not have version number which leads in vm deployment failure while checking router version > > > During the system vm build, arguments can be passed to build.sh script where 'version' argument is one of the optional arguments. The bug is even if version argument is not passed defalut value(CLOUDSTACK_RELEASE=4.4.0) is overridden by the null value (since argument is not passed). > > > Diffs > ----- > > tools/appliance/build.sh 8bf78b1 > > Diff: https://reviews.apache.org/r/26871/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > > --===============9134152384253876286==--