Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6563F17CDE for ; Thu, 9 Oct 2014 05:40:36 +0000 (UTC) Received: (qmail 41299 invoked by uid 500); 9 Oct 2014 05:40:36 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 41267 invoked by uid 500); 9 Oct 2014 05:40:36 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 41250 invoked by uid 99); 9 Oct 2014 05:40:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Oct 2014 05:40:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E81C71DDCF1; Thu, 9 Oct 2014 05:40:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3518326261335162586==" MIME-Version: 1.0 Subject: Review Request 26482: CLOUDSTACK-7688: Do not allow various operations which breaks VM Snapshots From: "Anshul Gangwar" To: "anthony xu" , "Devdeep Singh" Cc: "Anshul Gangwar" , "cloudstack" Date: Thu, 09 Oct 2014 05:40:31 -0000 Message-ID: <20141009054031.24817.50882@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Anshul Gangwar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/26482/ X-Sender: "Anshul Gangwar" Reply-To: "Anshul Gangwar" X-ReviewRequest-Repository: cloudstack-git --===============3518326261335162586== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26482/ ----------------------------------------------------------- Review request for cloudstack, anthony xu and Devdeep Singh. Bugs: CLOUDSTACK-7688 https://issues.apache.org/jira/browse/CLOUDSTACK-7688 Repository: cloudstack-git Description ------- VM snapshots stops working when following operations are performed on VM with VM snapshots 1. Volumes of VM are migrated to other storage 2. Add and remove NIC to/from VM 3. Attach and Detach volume to VM 4. Scale up/down of VM(change service offering) 5. Volume snapshot which is not major use case in this scenario 6. Resize volume 7. Live migration of VM which involves storage migration This patche adds the above restrictions Diffs ----- server/src/com/cloud/storage/VolumeApiServiceImpl.java e089b77 server/src/com/cloud/vm/UserVmManagerImpl.java 2636096 Diff: https://reviews.apache.org/r/26482/diff/ Testing ------- verified that all the above operations are not allowed Thanks, Anshul Gangwar --===============3518326261335162586==--