cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: master broken
Date Thu, 16 Oct 2014 17:36:49 GMT
what do you mean by just after the merge?

On Thu, Oct 16, 2014 at 7:28 PM, Marcus <shadowsor@gmail.com> wrote:

> The commit just before and just after the merge seem to work. They're both
> from the 15th.
>
>
> On Thu, Oct 16, 2014 at 11:12 AM, Nguyen Anh Tu <ng.tuna@gmail.com> wrote:
>
> > I've just tried the commit before HEAD. It worked!
> >
> > --Tuna
> >
> > On Fri, Oct 17, 2014 at 12:10 AM, Daan Hoogland <daan.hoogland@gmail.com
> >
> > wrote:
> >
> > > Marcus did you try the commit just before the merge? given the location
> > of
> > > the problem it might well be in the vpc refactor work or a combination
> of
> > > the both.
> > >
> > > I am trying myself as well now
> > >
> > >
> > > On Thu, Oct 16, 2014 at 7:07 PM, Marcus <shadowsor@gmail.com> wrote:
> > >
> > > > I can't rule out that it's specific to me at the moment, but I
> cleaned
> > my
> > > > repo and rebuilt with the same failure, then went back to the commit
> > just
> > > > before this and it succeeded.
> > > >
> > > > Wouldn't it have to be pushed first to pass any CI testing? So in
> > theory
> > > we
> > > > should never have CI catch compile errors if we don't push code that
> > > won't
> > > > compile.
> > > >
> > > > On Thu, Oct 16, 2014 at 11:03 AM, Daan Hoogland <
> > daan.hoogland@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > On Thu, Oct 16, 2014 at 6:57 PM, Marcus <shadowsor@gmail.com>
> wrote:
> > > > >
> > > > > > We probably shouldn't be
> > > > > > pushing code into the repo that we haven't tried to compile.
> > > > > >
> > > > >
> > > > > ‚Äčas I understand it it passed travis‚Äč, I agree otherwise
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Daan
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Daan
> > >
> >
>



-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message