cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject happy flow problem in network restart
Date Thu, 23 Oct 2014 11:48:13 GMT
H,

I encountered this

<diff>
diff --git a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
b/engine/orchestration/src/org/apache/clou
index ab5a21c..8b47289 100755
--- a/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
+++ b/engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
@@ -2464,12 +2464,11 @@ public class NetworkOrchestrator extends
ManagerBase implements NetworkOrchestra
         try {
             implementNetworkElementsAndResources(dest, context,
network, offering);
             setRestartRequired(network, true);
+            return true;
         } catch (Exception ex) {
             s_logger.warn("Failed to implement network " + network +
" elements and resources as a part of network restart due to ", ex);
             return false;
         }
-        setRestartRequired(network, false);
-        return true;
     }

     private void setRestartRequired(NetworkVO network, boolean
restartRequired) {
</diff>

As you can see the happy flow does a setRestartRequired with true and
as first next statement it sets it to false on the same network. It
seems wrong to me so I made the change described by the diff but
before committing I would like to hear if I am missing some
side-effect. (has happened with commits in the past, mine and other
peoples')

-- 
Daan

Mime
View raw message