cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wido den Hollander" <w...@widodh.nl>
Subject Re: Review Request 27393: Fix for Resize RBD Root Disk on Deploy
Date Fri, 31 Oct 2014 21:03:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27393/#review59415
-----------------------------------------------------------

Ship it!


Seems good to me! I'll apply it.

- Wido den Hollander


On Oct. 30, 2014, 8:37 p.m., Logan B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27393/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2014, 8:37 p.m.)
> 
> 
> Review request for cloudstack and Wido den Hollander.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently if you specify a root disk size when deploying an instance using Ceph RBD as
the Primary Storage backend the disk will not be resized.
> 
> This patch adds a check after deploying an instance that checks the specified root disk
volume size against the size of the template it was deployed from.  If the specified volume
size is larger than the template it will resize the root disk volume to the specified size.
> 
> If the specified volume size is equal to or smaller than the template size then no resizing
occurs, and the instance will be deployed with a root disk size equal to the size of the template.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
af7a0e0 
> 
> Diff: https://reviews.apache.org/r/27393/diff/
> 
> 
> Testing
> -------
> 
> Test: Created new instance from 5GB template with 20GB root disk size specified.
> Result: Instance created successfully with 20GB volume size.
> 
> Test: Created new instance from 5GB template with 5GB root disk size specified.
> Result: Instance created successfully with 5GB volume size.
> 
> Test: Created new instance from 5GB template with 1GB root disk size specified.
> Result: Instance created successfully with 5GB volume size.
> 
> Test: Created new instance from 5GB template with no root disk size specified.
> Result: Instance created successfully with 5GB volume size.
> 
> Patch was deployed to our production infrastructure on July 25th, 2014.  It's been running
stable since that time.
> 
> 
> Thanks,
> 
> Logan B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message