cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Brett" <alex.br...@citrix.com>
Subject Re: Review Request 27017: CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to remove dependency
Date Fri, 31 Oct 2014 11:46:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27017/#review59327
-----------------------------------------------------------



test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/27017/#comment100591>

    Is this supposed to be commented out (in which case it should probably just be removed),
or is this leftover from debugging?



test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/27017/#comment100592>

    It might be better to put this function in Marvin as a library function for other tests?



test/integration/component/test_escalations_snapshots.py
<https://reviews.apache.org/r/27017/#comment100593>

    This looks almost identical to the previous one (other than obviously grabbing memory),
would it be worth having these methods call a shared method with just a parameter as to whether
to include memory or not, to avoid code duplication?
    
    (The risk is someone fixes a bug in one, but not the other or whatever)


- Alex Brett


On Oct. 31, 2014, 4:37 a.m., Vinay Varma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27017/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2014, 4:37 a.m.)
> 
> 
> Review request for cloudstack, Alex Brett and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6282
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6282: Added newly automated tests and also modified some existing tests to
remove dependency
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_instances.py 1aaa688 
>   test/integration/component/test_escalations_snapshots.py 4b6b7f5 
>   test/integration/component/test_escalations_templates.py 78028bc 
>   test/integration/component/test_escalations_volumes.py 7290325 
>   test/integration/component/test_escalations_vpncustomergateways.py b09930a 
>   tools/marvin/marvin/cloudstackTestClient.py ce7ffc9 
>   tools/marvin/marvin/lib/base.py 77faeeb 
> 
> Diff: https://reviews.apache.org/r/27017/diff/
> 
> 
> Testing
> -------
> 
> Attached are the results files for each of the file modified and the results shows everything
is fine
> 
> 
> File Attachments
> ----------------
> 
> Instancesresults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/10/22/6ea95260-f31e-4fdd-a9f3-f30bac872df5__Instancesresults.txt
> Snapshotsresults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/10/22/a91e862c-dc2e-403e-85e4-6479eefcd9d1__Snapshotsresults.txt
> Templatesresults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/10/22/545fd06e-4975-4330-8390-3723d944ec2b__Templatesresults.txt
> Voumesresults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/10/22/9932b16c-684f-41ce-b6f9-192fe887c2b8__Voumesresults.txt
> VPNCustomerGatewaysresults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/10/22/58c5f08e-cac7-4873-a922-8c874a9a8e3a__VPNCustomerGatewaysresults.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message