cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 26640: CLOUDSTACK-7698: Do not create nat rule/acquire public IP by default while deploying VM if it is not necessary
Date Thu, 30 Oct 2014 09:42:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26640/#review59160
-----------------------------------------------------------


Applying: CLOUDSTACK-7698: Do not create nat rule/acquire public IP by default while deploying
VM if it is not necessary
error: patch failed: test/integration/smoke/test_nic.py:19
error: test/integration/smoke/test_nic.py: patch does not apply
Patch failed at 0001 CLOUDSTACK-7698: Do not create nat rule/acquire public IP by default
while deploying VM if it is not necessary
The copy of the patch that failed is found in:
   /Users/talluri/asf/cloudstack/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

- SrikanteswaraRao Talluri


On None, Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26640/
> -----------------------------------------------------------
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7698
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7698
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When parameter "mode" is passed while deploying VM, following code is executed to make
VM accessible via SSH.
> 
> In Advanced zone,
> Public IP is acquired in network, Firewall is opened, NAT rule is created
> 
> In Basic zone,
> New security group is created is default group is not present, else VM is added to default
security group which has ingress rule enabled.
> 
> In many test cases, mode is passed even when "Making Vm accessible via SSH" is not necessary.
Hence removing this parameter in such cases will prevent test cases from acquiring resources
which it doesn't need.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py bc9be6f 
>   test/integration/component/test_escalations_isos.py 4e818a5 
>   test/integration/component/test_explicit_dedication.py 71c4141 
>   test/integration/component/test_implicit_planner.py b538a3d 
>   test/integration/component/test_lb_secondary_ip.py 23ff1ee 
>   test/integration/component/test_multiple_ip_ranges.py 32c39f7 
>   test/integration/component/test_portable_ip.py cf0cb3b 
>   test/integration/component/test_recurring_snapshots.py 58dd769 
>   test/integration/component/test_snapshots_improvement.py 6638ddd 
>   test/integration/component/test_stopped_vm.py 1a928cc 
>   test/integration/component/test_storage_motion.py acbf92d 
>   test/integration/component/test_tags.py c5a8ced 
>   test/integration/component/test_templates.py 769848d 
>   test/integration/component/test_usage.py 81cce48 
>   test/integration/smoke/test_nic.py 488ed0a 
>   test/integration/smoke/test_reset_vm_on_reboot.py 668c77f 
>   test/integration/smoke/test_scale_vm.py 3a2983e 
>   test/integration/smoke/test_templates.py 4153ca3 
> 
> Diff: https://reviews.apache.org/r/26640/diff/
> 
> 
> Testing
> -------
> 
> Have tested for syntax and import errors.
> Have made changes only in those test cases which don't use the default public IP for
SSH which would otherwise get associated with the VM when mode was passed. (Hence only the
test cases which unnecessarily passing the mode parameter)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message