cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 27269: CLOUDSTACK-7800: VMware - Hot plug/unplug NIC to/from VM only when vmware tools are installed, else assert for exception
Date Wed, 29 Oct 2014 01:55:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27269/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 7:25 a.m.)


Review request for cloudstack, Raj Kumar and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7800
    https://issues.apache.org/jira/browse/CLOUDSTACK-7800


Repository: cloudstack-git


Description
-------

Starting vCenter 5.5 it has been made strict that hot unplug requires vmware tools installed
on the guest os.

VMware will report error if the vmtools are not installed.

The tests that are trying hot plug and unplug of nic on vms running on vmware, must check
for vmware tools running on the vm.
if the vm does not have tools => assert true for the exception.
if vm has vm tools running => Then only try for plug/unplug of nic.

In case of any other hypervisor, test suite will perform all the steps as it is.


Other changes:
1. Pep8 fixes
2. Changing from import * to specific imports


Diffs
-----

  test/integration/smoke/test_nic.py 488ed0a 

Diff: https://reviews.apache.org/r/27269/diff/


Testing
-------

Tested with vmware tools not installed on VM scenario. (KVM and Vmware)
I could not get the tools installed on VM.

Log:
Test to add and update added nic to a virtual machine ... === TestName: test_01_nic | Status
: SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 304.106s

OK


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message