cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Federle" <brian.fede...@citrix.com>
Subject Re: Review Request 27300: CLOUDSTACK-7766: Field Validations Missing for Ingress and Egress Rules
Date Tue, 28 Oct 2014 21:34:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27300/#review58881
-----------------------------------------------------------


Gabor, I am getting an error from this on the add VPC dialog, for the new validation present
on the network domain field:

                                     networkdomain: {
                                         docID: 'helpVPCDomain',
-                                        label: 'label.DNS.domain.for.guest.networks'
+                                        label: 'label.DNS.domain.for.guest.networks',
+                                        validation: {
+                                            ipv4: true
+                                        }
                                     },
                                     
Uncaught TypeError: Cannot read property 'call' of undefined 


-- I think this might be because your other patch for CLOUDSTACK-7765 wasn't applied yet (due
to conflicts), but can you confirm if you are able to reproduce this issue or not, once fixing
the other patch?

- Brian Federle


On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27300/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 7:16 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-7766
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7766
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Field Validations for the Start Port, End Port and CIDR fields
> Ingress and Egress rules.
> 
> NOTE: In order for this patch to work it needs [CLOUDSTACK-7765: Field Validations Missing
for VPC IP Address] applied before.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/network.js 9d79d3fa8b391ce0ad652ae35d9c3f52bae477a3 
>   ui/scripts/ui/widgets/multiEdit.js c4de8cecbe296607dac90a2c1eb6d362e33b1033 
> 
> Diff: https://reviews.apache.org/r/27300/diff/
> 
> 
> Testing
> -------
> 
> Tested validation on these fields
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message