cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 26442: CLOUDSTACK-7685: Fixed copy template method call in test_escalations_template.py. Removed unbound method of the same name as bound method from base l ibrary and changed method call accordingly
Date Mon, 20 Oct 2014 05:39:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26442/
-----------------------------------------------------------

(Updated Oct. 20, 2014, 11:09 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7685
    https://issues.apache.org/jira/browse/CLOUDSTACK-7685


Repository: cloudstack-git


Description (updated)
-------

Error details:
unbound method copy() must be called with Template instance as first argument (got CloudStackAPIClient
instance instead)

Reason:
There are bound and unbound methods "copy" in Template class with the same name. Apparently
when bound and unbound methods with same name are defined, call to unbound method fails.

Solution:
Keep only bound method.

Please note that I have ensured no test case makes call to unbound method (Template.copy).


Diffs
-----

  test/integration/component/test_escalations_templates.py 78028bc 
  tools/marvin/marvin/lib/base.py 77faeeb 

Diff: https://reviews.apache.org/r/26442/diff/


Testing
-------

Tested with python command/pyflakes.


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message