cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nitin Mehta" <nitin.me...@citrix.com>
Subject Re: Review Request 26871: CLOUDSTACK-7748: Cloudstack version number is missing in system vm template.
Date Fri, 17 Oct 2014 17:41:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26871/#review57173
-----------------------------------------------------------



tools/appliance/build.sh
<https://reviews.apache.org/r/26871/#comment97683>

    Why should version be optional at all ? 
    1. I think it should be mandatory.
    2. I would like you to do a more harder check on version making sure it is in correct
format as per expectations say it should be > 1.0 and less than say 10.0 < it should
be an integer etc.


- Nitin Mehta


On Oct. 17, 2014, 5:30 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26871/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 5:30 p.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7748
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7748
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-7748: Cloudstack version number is missing in system vm template.
>     /etc/cloudstack-release in system vm does not have version number which leads in
vm deployment failure while checking router version
>     
>     
>     During the system vm build, arguments can be passed to build.sh script where 'version'
argument is one of the optional arguments. The bug is even if version argument is not passed
defalut value(CLOUDSTACK_RELEASE=4.4.0) is overridden by the null value (since argument is
not passed).
> 
> 
> Diffs
> -----
> 
>   tools/appliance/build.sh 8bf78b1 
> 
> Diff: https://reviews.apache.org/r/26871/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message