cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 26489: CLOUDSTACK-7690: Added missing unittest import to test_escalations_volumes.py
Date Wed, 15 Oct 2014 05:33:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26489/#review56667
-----------------------------------------------------------

Ship it!


ac820a3230cc8a7358a4d9d27039d69f230734ea 4.5
bd9d57e20c4f8bd49fd403841cff909016987ced master

- SrikanteswaraRao Talluri


On Oct. 9, 2014, 7:56 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26489/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 7:56 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7690
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7690
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Below commit added functionality to skip the tests in case of hyperv and uses "unittest.SkipTest"
but unittest import is absent.
> 
> commit d7dea70e89e45b0864bfbcaab3b58f896a6c75c1
> Author: VinayV <vinay.vegesna@citrix.com>
> Date:   Wed Oct 1 13:53:37 2014 +0530
> 
>     CLOUDSTACK-6282-Added hyper-v hypervisor checks for automated tests\
>     
>     
> 
> 
> Changes:
> 1. Added missing import
> 2. Fixed all pep8 issues
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_volumes.py bf5e37c 
> 
> Diff: https://reviews.apache.org/r/26489/diff/
> 
> 
> Testing
> -------
> 
> Checked with pyflakes and python command.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message