Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BAF24118BD for ; Wed, 3 Sep 2014 08:33:32 +0000 (UTC) Received: (qmail 30245 invoked by uid 500); 3 Sep 2014 08:33:31 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 30194 invoked by uid 500); 3 Sep 2014 08:33:31 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 30178 invoked by uid 99); 3 Sep 2014 08:33:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2014 08:33:31 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of daan.hoogland@gmail.com designates 209.85.213.170 as permitted sender) Received: from [209.85.213.170] (HELO mail-ig0-f170.google.com) (209.85.213.170) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2014 08:33:27 +0000 Received: by mail-ig0-f170.google.com with SMTP id h3so4951829igd.3 for ; Wed, 03 Sep 2014 01:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=S4MFzjFm2YRHBbIqPi+GaLO+4ofgxY8jSoIj0YQZ1F8=; b=0Ybh4WXLsYEUtJdi3BX8sEZf77R3YmiiUw6sFMP05CtaGv98gQtYfaY52LSRLDkF9d lSZNkE0oDIEHkCcx2+pI58s5V7waaPC7ibkn2C8QzZsM4F7Z/P1m+qTVWGaCzqbLm3x/ ZDNtSi63WSyi8sr5ButCvQtx0xVWVDQUoDPbmjpzLQksou4nF4Mw+Fv9oAC1WEUSyNuv z1ip/PNIqUGRdDVMgQsDTZq2f15hKJSBxqX/98bnlF6ZiGcp4AGQc0SXs2J2PfDzdXRw hS/mFKESdxzV+YVhTOQxlKd9ZMdoFh7LfhApEvZs3VPOI/WI8QjTYXP4WtoHhKYdcK+p SvmQ== X-Received: by 10.50.128.225 with SMTP id nr1mr18418227igb.19.1409733186889; Wed, 03 Sep 2014 01:33:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.155.79 with HTTP; Wed, 3 Sep 2014 01:32:46 -0700 (PDT) In-Reply-To: References: <5405C76F.3050807@widodh.nl> <3F69D593-FC40-4572-86B9-1D3BBE2D5D24@shapeblue.com> <5405DA20.8050905@cloudops.com> <1719A8EC-CE4F-4A33-9ADF-E42B84D226AE@shapeblue.com> <5405DD18.9070001@cloudops.com> <84E5B8E9-FE53-456B-B06F-18C941EF509F@shapeblue.com> From: Daan Hoogland Date: Wed, 3 Sep 2014 10:32:46 +0200 Message-ID: Subject: Re: Cherry-picking fix that may change 4.3.1 schema To: dev Cc: "fgaudreault@cloudops.com" Content-Type: multipart/alternative; boundary=047d7b10cc07d52f3405022515af X-Virus-Checked: Checked by ClamAV on apache.org --047d7b10cc07d52f3405022515af Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 4.3.1 to 4.4.1 then should contain all effort that is also in 4.3.0 to 4.4.= 0 I don't look forward to the work but it is doable. What bothers me most is that we are putting so much enegy into 4.3.1 at the moment while 4.4.1 is about to be rc'd. -- an anonymous commit to commit upgrade advocate / release manager On Wed, Sep 3, 2014 at 9:39 AM, Sebastien Goasguen wrote= : > > On Sep 2, 2014, at 11:28 AM, Rohit Yadav > wrote: > > > > > On 02-Sep-2014, at 5:07 pm, Francois Gaudreault < > fgaudreault@cloudops.com> wrote: > >> I see. Well, I think we were impacted by that too, and we made the > decision to move on 4.4.1-snap (even if it's technically less stable?) an= d > then upgrade to 4.4.1 GA (next week?) > >> > >> I personally don't think pulling back DB changes in lower releases is = a > good idea :S > >> > >> But that's only my opinion :) > > > > I raised a concrete issue regarding 4.3.1/4.4.1 release and I would lik= e > to stick to that only. I understand there are too many numbers, versions > and branches to follow, so please if you can try to understand the issue; > > I think Francois understands the issue (in terms of the bug been talked > about), and his solution has been to move to 4.4.1-snap. It is a differen= t > type of solution than a solution at the code/release level but if it work= s > for him..fine :) > > > > > This issue =E2=80=94 https://issues.apache.org/jira/browse/CLOUDSTACK-6= 756 > requires that there are some extra columns in the database to do book > keeping when delete ips so you don=E2=80=99t actually delete db/table row= s. > > > > The issue above is fixed in an upgrade path from 4.3.0 to 4.4.0: > > > https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3Dblobdiff;f= =3Dsetup/db/db/schema-430to440.sql;h=3D226260804523c79e3ce3cfa3c407b5ac698d= 749c;hp=3D3b525c41a1befd94c5ffc324c357b566606a97d0;hb=3Dce6a53e;hpb=3Dd0f80= 6b3a486c58b033083fc57f39dd686e31750 > > > > But, we already have 4.4.0 release and db upgrade paths are always in > the next release versions. > > > > So, there is no upgrade path from 4.3.1 to 4.4.0; as 4.3.1 version does > not care about 4.4.0 schema changes. There is only an upgrade path from > 4.3.0 to 4.3.1. So, the limitation is that people won=E2=80=99t be able t= o upgrade > from 4.3.1 to 4.4.0, because 4.4.0 is already released. > > > > If we release 4.4.1 before 4.3.1, we=E2=80=99ll have the same issue. So= , we can > put the fix from the JIRA issue on 4.3 branch so the issue is fixed for > 4.3.1. The fix will be in the 4.3.0 to 4.3.1 upgrade path. And, if we > release 4.4.1 after 4.3.1, we can fix the upgrade path from 4.3.1 to 4.4.= 1 > on 4.4 branch such that > > > > The abstract issue is =E2=80=94 we=E2=80=99ll have such issue in future= , how do we fix > it. I suggested =E2=80=94 we make a separate tool that does (rolling) upg= rades. > > > > So two things: > > -How to fix now > -How to fix later (if we want to keep some type of long term release > branches) > > I am ready to release 4.3.1 so if we put an upgrade path from 4.3.1 to > 4.4.1 , that's fine with me, especially if there is precedent of database > changes in the 4.2.x series. > > > Regards, > > Rohit Yadav > > Software Architect, ShapeBlue > > M. +41 779015219 | rohit.yadav@shapeblue.com > > Blog: bhaisaab.org | Twitter: @_bhaisaab > > > > > > > > Find out more about ShapeBlue and our range of CloudStack related > services > > > > IaaS Cloud Design & Build< > http://shapeblue.com/iaas-cloud-design-and-build//> > > CSForge =E2=80=93 rapid IaaS deployment framework > > CloudStack Consulting > > CloudStack Infrastructure Support< > http://shapeblue.com/cloudstack-infrastructure-support/> > > CloudStack Bootcamp Training Courses< > http://shapeblue.com/cloudstack-training/> > > > > This email and any attachments to it may be confidential and are > intended solely for the use of the individual to whom it is addressed. An= y > views or opinions expressed are solely those of the author and do not > necessarily represent those of Shape Blue Ltd or related companies. If yo= u > are not the intended recipient of this email, you must neither take any > action based upon its contents, nor copy or show it to anyone. Please > contact the sender if you believe you have received this email in error. > Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue > Services India LLP is a company incorporated in India and is operated und= er > license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a > company incorporated in Brasil and is operated under license from Shape > Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of > South Africa and is traded under license from Shape Blue Ltd. ShapeBlue i= s > a registered trademark. > > --=20 Daan --047d7b10cc07d52f3405022515af--