Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 15898176EE for ; Thu, 25 Sep 2014 14:55:58 +0000 (UTC) Received: (qmail 4520 invoked by uid 500); 25 Sep 2014 14:55:57 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 4468 invoked by uid 500); 25 Sep 2014 14:55:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 4449 invoked by uid 99); 25 Sep 2014 14:55:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 14:55:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AFB021DDA42; Thu, 25 Sep 2014 14:55:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2039667589093731547==" MIME-Version: 1.0 Subject: Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers From: "Rohit Yadav" To: "Vincent Bernat" , "cloudstack" , "Rohit Yadav" Date: Thu, 25 Sep 2014 14:55:54 -0000 Message-ID: <20140925145554.15000.18466@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/26035/ X-Sender: "Rohit Yadav" References: <20140925143134.15006.83166@reviews.apache.org> In-Reply-To: <20140925143134.15006.83166@reviews.apache.org> Reply-To: "Rohit Yadav" X-ReviewRequest-Repository: cloudstack-git --===============2039667589093731547== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26035/#review54540 ----------------------------------------------------------- Ship it! Ship It! - Rohit Yadav On Sept. 25, 2014, 2:31 p.m., Vincent Bernat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26035/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 2:31 p.m.) > > > Review request for cloudstack. > > > Bugs: CLOUDSTACK-7633 > https://issues.apache.org/jira/browse/CLOUDSTACK-7633 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-7633: fix "Provides" in most LSB headers > > In init.d scripts, the LSB header may specify what kind of service is > provided by an init script. If spaces are used, this means the init > script is providing several boot facilities. We fix that by using an > hyphen. > > > Diffs > ----- > > agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 > agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 > agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b > packaging/centos63/cloud-usage.rc 8434e4d568a0 > packaging/debian/init/cloud-agent eb2c3d14754b > packaging/debian/init/cloud-usage 06b1142172aa > python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 > python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 > usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a > usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a > usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 > usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a > usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 > usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 > > Diff: https://reviews.apache.org/r/26035/diff/ > > > Testing > ------- > > > Thanks, > > Vincent Bernat > > --===============2039667589093731547==--