Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 54C6A11C1B for ; Wed, 17 Sep 2014 12:22:22 +0000 (UTC) Received: (qmail 70937 invoked by uid 500); 17 Sep 2014 12:22:21 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 70890 invoked by uid 500); 17 Sep 2014 12:22:21 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 70875 invoked by uid 99); 17 Sep 2014 12:22:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Sep 2014 12:22:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 96B961DD3DD; Wed, 17 Sep 2014 12:22:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5646593627977251364==" MIME-Version: 1.0 Subject: Re: Review Request 25647: enabling the rootdisksize variable for vm creation wrt managed storage From: "punith s" To: "Mike Tutkowski" Cc: "punith s" , "cloudstack" Date: Wed, 17 Sep 2014 12:22:19 -0000 Message-ID: <20140917122219.7800.28206@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "punith s" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/25647/ X-Sender: "punith s" References: <20140916114634.7800.64412@reviews.apache.org> In-Reply-To: <20140916114634.7800.64412@reviews.apache.org> Reply-To: "punith s" X-ReviewRequest-Repository: cloudstack-git --===============5646593627977251364== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25647/ ----------------------------------------------------------- (Updated Sept. 17, 2014, 5:52 p.m.) Review request for cloudstack and Mike Tutkowski. Changes ------- removing the fix for IOPS null issue(will be posting it in another review), V3 only contains the fix for bug 7406 Bugs: 7406 https://issues.apache.org/jira/browse/7406 Repository: cloudstack-git Description ------- since cloudstack is not able to process the S3 or Switf templates for its virtual size(root disk size), admin is facing issues while creating a vm using third party storage plugins like cloudbyte and solidfire etc. this patch enables the resize of root disk, on passing a variable ismanagedstorage = true in deployVmCmd as a detail. hence template root disksize is overriden by the given rootdisk size by the admin this patch also fixes the iops null issue. for more ref https://issues.apache.org/jira/browse/CLOUDSTACK-7406 Diffs (updated) ----- server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 Diff: https://reviews.apache.org/r/25647/diff/ Testing ------- dry run only. Thanks, punith s --===============5646593627977251364==--