Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============7157821588106006225=="
MIME-Version: 1.0
Subject: Re: Review Request 25647: enabling the rootdisksize variable for vm
 creation wrt managed storage
From: "punith s" <punith.s@cloudbyte.com>
To: "amit kumar das" <amit.das@cloudbyte.com>,
 "Mike Tutkowski" <mike.tutkowski@solidfire.com>
Cc: "cloudstack" <dev@cloudstack.apache.org>,
 "punith s" <punith.s@cloudbyte.com>
Date: Tue, 16 Sep 2014 06:44:50 -0000
Message-ID: <20140916064450.7800.34239@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "punith s" <noreply@reviews.apache.org>
References: <20140915141145.7801.42052@reviews.apache.org>
In-Reply-To: <20140915141145.7801.42052@reviews.apache.org>
Reply-To: "punith s" <punith.s@cloudbyte.com>

--===============7157821588106006225==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25647/#review53488
-----------------------------------------------------------


engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
<https://reviews.apache.org/r/25647/#comment93132>

    yes mike, when you create a compute offering with  a specified min and max iops on contrary to the custom iops, iops was setting null for the root disk, since a new rootdiskoffering object is being created, predefined iops were not being set.
    
    and yes, this issue is not related to this S3 bug, but i thought it to be a minor one, so i clubbed it with this review.


- punith s


On Sept. 15, 2014, 7:41 p.m., punith s wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25647/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 7:41 p.m.)
> 
> 
> Review request for cloudstack, amit kumar das and Mike Tutkowski.
> 
> 
> Bugs: 7406
>     https://issues.apache.org/jira/browse/7406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> since cloudstack is not able to process the S3 or Switf templates for its virtual size(root disk size), admin is facing issues while creating a vm using third party storage plugins like cloudbyte and solidfire etc.
> this patch enables the resize of root disk, on passing a  variable ismanagedstorage = true in deployVmCmd as a detail.
> hence template root disksize is overriden by the given rootdisk size by the admin
> 
> this patch also fixes the iops null issue.
> 
> for more ref
> https://issues.apache.org/jira/browse/CLOUDSTACK-7406
> 
> 
> Diffs
> -----
> 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2b49954 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 
> 
> Diff: https://reviews.apache.org/r/25647/diff/
> 
> 
> Testing
> -------
> 
> dry run only.
> 
> 
> Thanks,
> 
> punith s
> 
>


--===============7157821588106006225==--