Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============4693865982954763286=="
MIME-Version: 1.0
Subject: Re: Review Request 25537: [UI][CLOUDSTACK-7525] Add "Edit Tags"
 functionality to SecurityGroup rules UI
From: "Wei Zhou" <w.zhou@leaseweb.com>
To: "Ian Duffy" <ian@ianduffy.ie>, "Nitin Mehta" <nitin.mehta@citrix.com>,
 "Wei Zhou" <w.zhou@leaseweb.com>, "Jessica Wang" <jessicawang@apache.org>,
 "Brian Federle" <brian.federle@citrix.com>,
 "Stephen Hoogendijk" <stephen@tca0.nl>
Cc: "Ilia Shakitko" <i.shakitko@tech.leaseweb.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Thu, 11 Sep 2014 13:48:00 -0000
Message-ID: <20140911134800.23924.69360@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Wei Zhou" <noreply@reviews.apache.org>
References: <20140911130642.23929.26324@reviews.apache.org>
In-Reply-To: <20140911130642.23929.26324@reviews.apache.org>
Reply-To: "Wei Zhou" <w.zhou@leaseweb.com>

--===============4693865982954763286==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25537/#review53031
-----------------------------------------------------------

Ship it!


Ship It!

- Wei Zhou


On 九月 11, 2014, 1:06 p.m., Ilia Shakitko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25537/
> -----------------------------------------------------------
> 
> (Updated 九月 11, 2014, 1:06 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Ian Duffy, Jessica Wang, Nitin Mehta, Stephen Hoogendijk, and Wei Zhou.
> 
> 
> Bugs: CLOUDSTACK-7525
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7525
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> An addition to the tagging support for security group rules: https://reviews.apache.org/r/24557/
> 
> Displays edit tags icon for every SecurityGroup Ingress/Egress rule and allows manage them.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/network.js 8a758c8 
> 
> Diff: https://reviews.apache.org/r/25537/diff/
> 
> 
> Testing
> -------
> 
> Tested on latest master (11th of September).
> 
> Screenshots are here: https://issues.apache.org/jira/browse/CLOUDSTACK-7525
> 
> Tags can be added and deleted from UI in different browsers, no exceptions/errors.
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>


--===============4693865982954763286==--