cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: Commit cd8af6a
Date Wed, 03 Sep 2014 18:25:50 GMT
H Min,

what is this fix for?


On Wed, Sep 3, 2014 at 8:20 PM, Min Chen <min.chen@citrix.com> wrote:

> Fix is checked into master branch. Can I back port it to 4.4?
>
> Thanks
> -min
>
> On 9/3/14 9:42 AM, "Min Chen" <min.chen@citrix.com> wrote:
>
> >Thanks Hugo for pointing that out. That is a bug caused by copy-and-paste,
> >the code should be in decrRefCnt routine like other SnapshotDataStoreVO
> >and TemplateDataStoreVO.
> >I will fix this in a minute.
> >
> >-min
> >
> >
> >On 9/3/14 12:30 AM, "Hugo Trippaers" <hugo@trippaers.nl> wrote:
> >
> >>Min,
> >>
> >>I¹m checking some findbugs reports and found the following piece of code
> >>in VolumeDataStoreVO (line 352):
> >>
> >>    public void setRefCnt(Long refCnt) {
> >>        if (refCnt > 0) {
> >>            refCnt--;
> >>        }
> >>        else {
> >>            s_logger.warn("We should not try to decrement a zero
> >>reference count even though our code has guarded");
> >>        }
> >>    }
> >>
> >>
> >>This doesn¹t seem to make a lot of sense to me as the refCnt field
> >>doesn¹t get set in this function. Could you have a look as you committed
> >>this and might know what the intended behavior is?
> >>
> >>Cheers,
> >>
> >>Hugo
> >
>
>


-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message