cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [DISCUSS] Prevent force push on release and master branches
Date Mon, 01 Sep 2014 09:52:49 GMT
Rajani, I agree that moving tags is not best practice but with our release
candidate custom it is better then not tagging until certain.


On Mon, Sep 1, 2014 at 11:25 AM, Rajani Karuturi <rajani@apache.org> wrote:

> If force push is disabled, feature branches wont be able to rebase on
> master directly unless they create a temp branch or do a merge.[1]
>
> Moving tags aren't recommended. see discussion on "Re-tagging" in git-tag
> man page [2]
>
> [1]
>
> http://stackoverflow.com/questions/8939977/git-push-rejected-after-feature-branch-rebase
> [2] https://www.kernel.org/pub/software/scm/git/docs/git-tag.html
>
>
>
> ~Rajani
>
>
> On Mon, Sep 1, 2014 at 1:45 PM, Rohit Yadav <rohit.yadav@shapeblue.com>
> wrote:
>
> >
> > On 01-Sep-2014, at 9:55 am, Daan Hoogland <daan.hoogland@gmail.com>
> wrote:
> >
> > > I worry that disabling force push will inhibit moving tags and deleting
> > > branches, two thing I definately want to keep on doing.
> >
> > I’ve worked on git hooks before, and you can still be able to delete tags
> > and branches if we were to disable force pushes. This is technically
> > possible.
> >
> >
> > >
> > >
> > > On Sat, Aug 30, 2014 at 3:15 AM, David Nalley <david@gnsa.us> wrote:
> > >
> > >> Projects do not have the ability to specify their own hooks. You
> > >> essentially get the same set as every other project in the Foundation
> > >> using git. The reasons behind this are that essentially projects would
> > >> have an incredibly divergent set of hooks, they would be
> > >> unmaintainable long term. Infra has had experiences in the past where
> > >> commit (or pre-commit) hooks were configurable and ended up causing
> > >> massive performance impacts; and were incredibly difficult to trace
> > >> down.
> > >>
> > >> Most hook functionality (though not in the case) can be accomplished
> > >> with gitpubsub, which is what a majority of folks do who want
> > >> hook-like functionality.
> > >>
> > >> You can ask/make the recommendation that the foundation disable force
> > >> pushes across all branches of all repositories at the foundation. That
> > >> may actually make a lot of sense. But I don't know that everyone will
> > >> agree. (I tend to concur, I can't think of a good reason one would do
> > >> a force push).
> > >>
> > >> --David
> > >>
> > >> On Fri, Aug 29, 2014 at 3:13 PM, Rohit Yadav <
> rohit.yadav@shapeblue.com
> > >
> > >> wrote:
> > >>> Hi David,
> > >>>
> > >>> On 29-Aug-2014, at 6:59 pm, David Nalley <david@gnsa.us> wrote:
> > >>>> force pushes on master are already prohibited.
> > >>>> The other branches allow that though.
> > >>>
> > >>> We already know this. The discussion is;
> > >>>
> > >>> 1. Should we put git hooks to prevent force pushes on all branches?
> > >> (people would be still able to delete any remote branches though,
> which
> > is
> > >> another issue IMO that you can delete any remote branch other than
> > master)
> > >>>
> > >>> 2. Any reason we should not do that, for example if anyone has a good
> > >> reason to use force push?
> > >>>
> > >>> Regards,
> > >>> Rohit Yadav
> > >>> Software Architect, ShapeBlue
> > >>> M. +41 779015219 | rohit.yadav@shapeblue.com
> > >>> Blog: bhaisaab.org | Twitter: @_bhaisaab
> > >>>
> > >>>
> > >>>
> > >>> Find out more about ShapeBlue and our range of CloudStack related
> > >> services
> > >>>
> > >>> IaaS Cloud Design & Build<
> > >> http://shapeblue.com/iaas-cloud-design-and-build//>
> > >>> CSForge – rapid IaaS deployment framework<
> > http://shapeblue.com/csforge/>
> > >>> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
> > >>> CloudStack Infrastructure Support<
> > >> http://shapeblue.com/cloudstack-infrastructure-support/>
> > >>> CloudStack Bootcamp Training Courses<
> > >> http://shapeblue.com/cloudstack-training/>
> > >>>
> > >>> This email and any attachments to it may be confidential and are
> > >> intended solely for the use of the individual to whom it is addressed.
> > Any
> > >> views or opinions expressed are solely those of the author and do not
> > >> necessarily represent those of Shape Blue Ltd or related companies. If
> > you
> > >> are not the intended recipient of this email, you must neither take
> any
> > >> action based upon its contents, nor copy or show it to anyone. Please
> > >> contact the sender if you believe you have received this email in
> error.
> > >> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
> > >> Services India LLP is a company incorporated in India and is operated
> > under
> > >> license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a
> > >> company incorporated in Brasil and is operated under license from
> Shape
> > >> Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic
> > of
> > >> South Africa and is traded under license from Shape Blue Ltd.
> ShapeBlue
> > is
> > >> a registered trademark.
> > >>
> > >
> > >
> > >
> > > --
> > > Daan
> >
> > Regards,
> > Rohit Yadav
> > Software Architect, ShapeBlue
> > M. +41 779015219 | rohit.yadav@shapeblue.com
> > Blog: bhaisaab.org | Twitter: @_bhaisaab
> >
> >
> >
> > Find out more about ShapeBlue and our range of CloudStack related
> services
> >
> > IaaS Cloud Design & Build<
> > http://shapeblue.com/iaas-cloud-design-and-build//>
> > CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
> > CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
> > CloudStack Infrastructure Support<
> > http://shapeblue.com/cloudstack-infrastructure-support/>
> > CloudStack Bootcamp Training Courses<
> > http://shapeblue.com/cloudstack-training/>
> >
> > This email and any attachments to it may be confidential and are intended
> > solely for the use of the individual to whom it is addressed. Any views
> or
> > opinions expressed are solely those of the author and do not necessarily
> > represent those of Shape Blue Ltd or related companies. If you are not
> the
> > intended recipient of this email, you must neither take any action based
> > upon its contents, nor copy or show it to anyone. Please contact the
> sender
> > if you believe you have received this email in error. Shape Blue Ltd is a
> > company incorporated in England & Wales. ShapeBlue Services India LLP is
> a
> > company incorporated in India and is operated under license from Shape
> Blue
> > Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
> Brasil
> > and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd
> is
> > a company registered by The Republic of South Africa and is traded under
> > license from Shape Blue Ltd. ShapeBlue is a registered trademark.
> >
>



-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message