cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Brett" <alex.br...@citrix.com>
Subject Re: Review Request 24882: CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are not applicable for hyper-v
Date Mon, 29 Sep 2014 10:42:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24882/#review54798
-----------------------------------------------------------



test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/24882/#comment95069>

    Minor one but where we're checking multiple hypervisors to skip I'd have done e.g. "if
self.hypervisor.lower() in ['kvm', 'hyperv']:" or similar rather than have two separate ifs...



test/integration/component/test_escalations_isos.py
<https://reviews.apache.org/r/24882/#comment95074>

    You don't need this as you've already got above:
    from marvin.lib.utils import *


- Alex Brett


On Sept. 29, 2014, 7:13 a.m., Vinay Varma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24882/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 7:13 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6282
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are
not applicable for hyper-v
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_instances.py 73ebf13 
>   test/integration/component/test_escalations_ipaddresses.py b29cd1d 
>   test/integration/component/test_escalations_isos.py 925c2fb 
>   test/integration/component/test_escalations_networks.py c0ab709 
>   test/integration/component/test_escalations_snapshots.py 8d289e1 
>   test/integration/component/test_escalations_volumes.py 8d6ba99 
> 
> Diff: https://reviews.apache.org/r/24882/diff/
> 
> 
> Testing
> -------
> 
> Executed the tests and attached are the log files for each of the files changed.
> 
> 
> File Attachments
> ----------------
> 
> InstancesResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/4ac84a27-fc7c-4b8c-9509-d75a350b53a3__InstancesResults.txt
> IPAddressesResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/14aad713-9256-44ed-a9e2-d7225c5c975c__IPAddressesResults.txt
> IsoResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/516de1c8-09d0-4e07-abe4-3483463750c3__IsoResults.txt
> SnapshotsResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/46f2a6c3-f0f7-4397-918e-bb8df1d63e97__SnapshotsResults.txt
> VolumeResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/28d59100-315b-45e8-9aaa-b60982571637__VolumeResults.txt
> NetworksResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/869b26e2-9fc2-44cf-bbc1-fc13fd60bc58__NetworksResults.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message