cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request 25820: CLOUDSTACK-7575: Improve performance of cleanString method in StringUtils
Date Fri, 26 Sep 2014 08:53:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25820/#review54658
-----------------------------------------------------------

Ship it!


Committed changes in 7972f53c8d35b78bd27cbd2c8bb1beb763b69c00

- Devdeep Singh


On Sept. 19, 2014, 5:51 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25820/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 5:51 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> We are using two regular expressions to clean sensitive data from logged string. One
regular expression is cleaning from middle while other from end. This patch combines those
two regular expressions in one regular expression
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/StringUtils.java 7014e5c 
> 
> Diff: https://reviews.apache.org/r/25820/diff/
> 
> 
> Testing
> -------
> 
> tested the strings are cleaned up properly of passwords after the changes
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message