cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request 26035: CLOUDSTACK-7633: fix "Provides" in most LSB headers
Date Thu, 25 Sep 2014 14:12:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26035/#review54536
-----------------------------------------------------------


I think they all should start with a "cloudstack-", I'm not sure but does this cause any issue
for you? And I think they would be applicable on master, 4.4 branches as well.

- Rohit Yadav


On Sept. 25, 2014, 1:31 p.m., Vincent Bernat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26035/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 1:31 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-7633
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7633
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-7633: fix "Provides" in most LSB headers
> 
> In init.d scripts, the LSB header may specify what kind of service is
> provided by an init script. If spaces are used, this means the init
> script is providing several boot facilities. We fix that by using an
> hyphen.
> 
> 
> Diffs
> -----
> 
>   agent/distro/opensuse/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 
>   agent/distro/sles/SYSCONFDIR/init.d/cloud-agent.in 741317bde439 
>   agent/distro/ubuntu/SYSCONFDIR/init.d/cloud-agent.in 0e8705307e8b 
>   packaging/centos63/cloud-usage.rc 8434e4d568a0 
>   packaging/debian/init/cloud-agent eb2c3d14754b 
>   packaging/debian/init/cloud-usage 06b1142172aa 
>   python/distro/opensuse/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 
>   python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in 558f5a2ee986 
>   usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a 
>   usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a 
>   usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 
>   usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5cff1a 
>   usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 
>   usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f9682635b1e9 
> 
> Diff: https://reviews.apache.org/r/26035/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vincent Bernat
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message