cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sanjeev n" <sanjeev.neelar...@citrix.com>
Subject Re: Review Request 25536: Adding new test case to verify the fix for issue "Exception when attaching data disk to Rhel vm on vSphere"
Date Tue, 23 Sep 2014 11:49:47 GMT


> On Sept. 19, 2014, 6:03 a.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/test_escalations_vmware.py, line 19
> > <https://reviews.apache.org/r/25536/diff/1/?file=685097#file685097line19>
> >
> >     can you please avoid import * ?

commit 5fb2b3a0d24c2bcda0745a6b8ff59fae5651e054
Author: sanjeev <sanjeev@apache.org>
Date:   Wed Sep 10 11:55:26 2014 +0530

    Test to verify fix for issue "Exception when attaching data disk to RHEL vm on vSphere

    Added Rhel6 template details to test_data.py

    Signed-off-by: sanjeev <sanjeev@apache.org>

    Fixed review comments provided in RR 25536


- sanjeev


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25536/#review53939
-----------------------------------------------------------


On Sept. 11, 2014, 10:31 a.m., sanjeev n wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25536/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 10:31 a.m.)
> 
> 
> Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> @desc: Exception when attaching data disk to RHEL VM on vSphere
> Step1: Confirm that vmware.root.disk.controller = "ide" in Global Settings.
> Step2: Register RHEl 6.0 template and deploy a VM.
> Step3: Note that the root disk is attached to IDE.
> Step4: Create new DATA disk and attempt to attach it to the VM.
> Verify that step4 succeeds without any exception
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_vmware.py PRE-CREATION 
>   tools/marvin/marvin/config/test_data.py 4133aba 
> 
> Diff: https://reviews.apache.org/r/25536/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> sanjeev n
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message