cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anshul Gangwar" <anshul.gang...@citrix.com>
Subject Review Request 25934: Fixed various bugs in AlertsSyslogAppender
Date Tue, 23 Sep 2014 09:30:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25934/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi.


Bugs: CLOUDSTACK-7610, CLOUDSTACK-7611 and CLOUDSTACK-7612
    https://issues.apache.org/jira/browse/CLOUDSTACK-7610
    https://issues.apache.org/jira/browse/CLOUDSTACK-7611
    https://issues.apache.org/jira/browse/CLOUDSTACK-7612


Repository: cloudstack-git


Description
-------

Fixed following bugs in AlertsSyslogAppender
    1. Added sync alert.
    2. Changed unrecognised alerts are send as unknown instead of null.
    3. Added unit tests to cover some more scenarios.


Diffs
-----

  plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java
5f6e8ec 
  plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java
5799348 

Diff: https://reviews.apache.org/r/25934/diff/


Testing
-------

Added unit tests and all were passing fine


Thanks,

Anshul Gangwar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message