cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 25685: Fixed the test_usage.py script bug - CLOUDSTACK-7555
Date Tue, 23 Sep 2014 06:37:00 GMT


> On Sept. 16, 2014, 11:25 a.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/test_usage.py, line 748
> > <https://reviews.apache.org/r/25685/diff/1/?file=690448#file690448line748>
> >
> >     Please change this to self.account.name and self.account.domainid
> 
> Chandan Purushothama wrote:
>     Talluri,
>     account is a class attribute. It is not conventionally correct to refer a class attribute
using object reference(self). Hence I intentionally referenced the account via its Class name,
>     
>     Thank you,
>     Chandan.

cool. i suggested the above since those class attributes can also be accessed by their instances.


- SrikanteswaraRao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25685/#review53506
-----------------------------------------------------------


On Sept. 16, 2014, 6:46 a.m., Chandan Purushothama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25685/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 6:46 a.m.)
> 
> 
> Review request for cloudstack, sangeetha hariharan, sanjeev n, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7555
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7555
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> 
> TestTemplateUsage.test_01_template_usage fails with the following error message &
Stack Trace
> 
> Stacktrace
> 
>   File "/usr/lib/python2.7/unittest/case.py", line 332, in run
>     testMethod()
>   File "/root/cloudstack/test/integration/component/test_usage.py", line 802, in test_01_template_usage
>     "Check TEMPLATE.CREATE event in events table"
>   File "/usr/lib/python2.7/unittest/case.py", line 516, in assertEqual
>     assertion_func(first, second, msg=msg)
>   File "/usr/lib/python2.7/unittest/case.py", line 509, in _baseAssertEqual
>     raise self.failureException(msg)
> 'Check TEMPLATE.CREATE event in events table\n
> 
> This is because the Template is being created as admin and it belongs to the admin account.
The template should belong to the Regular User in order to check for the TEMPLATE.CREATE Event.
> 
> Fixed the script such that the Template now belongs to the regular account.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_usage.py e99bb81 
> 
> Diff: https://reviews.apache.org/r/25685/diff/
> 
> 
> Testing
> -------
> 
> No testing is done.
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message