cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Tutkowski" <mike.tutkow...@solidfire.com>
Subject Re: Review Request 25732: null IOPS is being processed while creating a vm using third party storage plugins
Date Fri, 19 Sep 2014 22:09:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25732/#review54035
-----------------------------------------------------------

Ship it!


Ship It!

- Mike Tutkowski


On Sept. 17, 2014, 6:28 a.m., punith s wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25732/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 6:28 a.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Bugs: CLOUDSTACK-7570
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7570
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> this bug will only occur in the following scenario
> 1> create a compute offering with custom mode but not custom IOPS
> 2> input the required min and max IOPS
> 3> now create a VM based on the created compute offering
> 
> issue:
> ServiceOfferingVO dummyoffering = new ServiceOfferingVO(serviceOffering);
> this constructor is not setting the min and max IOPS for the dummyoffering
> 
> fix: 
> adding the min and max iops to the following constructor.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/service/ServiceOfferingVO.java df68fb8 
>   engine/schema/src/com/cloud/storage/DiskOfferingVO.java 152fa2c 
> 
> Diff: https://reviews.apache.org/r/25732/diff/
> 
> 
> Testing
> -------
> 
> system testing done
> 
> 
> Thanks,
> 
> punith s
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message